github-fixes-#31-error-maximum-call-stack-exceeded#39
Merged
DanaShalev merged 2 commits intoDec 31, 2017
Conversation
eitanp461
approved these changes
Dec 28, 2017
Contributor
|
@DanaShalev in the commit message (when merging) add that this fixes #31 and #20 |
… it is not used anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Image.shouldComponentUpdatesince React already compares the element before changing the DOM. Since theImage.rendermethod is less expensive thanImage.shouldComponentUpdatewe are better off without it.