Skip to content

Add workaround for #31 (infinite loop in shouldComponentUpdate)#32

Closed
bernharduw wants to merge 1 commit into
cloudinary:masterfrom
bernharduw:feature/workaround-for-react-16-cycle
Closed

Add workaround for #31 (infinite loop in shouldComponentUpdate)#32
bernharduw wants to merge 1 commit into
cloudinary:masterfrom
bernharduw:feature/workaround-for-react-16-cycle

Conversation

@bernharduw
Copy link
Copy Markdown

Cycle detection flag set to true for equals(). This is not the best solution, but for now this works.

@eitanp461
Copy link
Copy Markdown
Contributor

@bernharduw we've removed the usage in equals in version 1.0.6 we've released recently.
Please check if it solves your problem, and update this pull request if it does.
Thanks in advance.

@eitanp461
Copy link
Copy Markdown
Contributor

Closing due to elapsed time. Issue has been fixed by #39

@eitanp461 eitanp461 closed this Feb 12, 2018
@bernharduw
Copy link
Copy Markdown
Author

I can confirm this is solved by #39. Sorry for the late reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants