Add regression test for PySet_Contains #141411
Open
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
Carreau
force-pushed
the
reg-test-gh-132657
branch
from
3434a3d to
9d02192
Compare
| static PyObject * | ||
| test_set_contains_does_not_convert_unhashable_key(PyObject *self, PyObject *Py_UNUSED(obj)) | ||
| { | ||
| // The documentation of PySet_Contains state: |
Contributor
There was a problem hiding this comment.
You can just add a link to docs, the code is self-explanatory of the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in gh-141183, the test suite did not
test that
PySet_Containsdoes not convert unhashable key into a frozenset.This commit adds a regression test for this
behavior, to ensure that any behavior change is
caught by the test suite.
--
I'm not sure opening a GitHub issue, or having a blurb is necessary as this only adds a test.
Here is the link to the comment where @kumaraditya303 suggested for me to send a test as a separate PR.