gh-99138: Isolate _zoneinfo

[erlend-aasland]

• Issue: Port zoneinfo module to use module state #99138

[erlend-aasland]

@pganssle I can break this up in several PRs; let me know what works best for you.

[erlend-aasland]

Do we need the defining_class converter for @classmethods?

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 573aec1 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

[sobolevn]

You've beat me to it :)
Thanks!

[erlend-aasland]

You've beat me to it :)
Thanks!

Sorry, I was not aware that you were working on a PR; I should've asked first.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 6e69e93 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

[kumaraditya303]

LGTM

[erlend-aasland]

Thanks for the review, Kumar. I'll wait until Monday with landing this, to give @pganssle a chance to chime in.

[pganssle]

One minor suggestion here, and it's mostly a documentation thing, otherwise this looks good to me!

Thanks for doing this Erland, sorry for the long delay in reviewing.

Hopefully the tests I put in place for the cache stuff are robust 😅 That kind of thing is hard to test well, and this is the kind of change that really needs it 😛

[bedevere-bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[erlend-aasland]

Hopefully the tests I put in place for the cache stuff are robust 😅 That kind of thing is hard to test well, and this is the kind of change that really needs it 😛

Yeah, I know, changes like this need really good test suites! I'll take a look at the coverage before and after the change, just to see that we've at least got all the branches covered.

Thanks for the review 🙂

[erlend-aasland]

Good to go, @pganssle?

[pganssle]

Looks good to me! Thanks again for doing this @erlend-aasland and thanks for doing the heavy lifting in the review @kumaraditya303

[pganssle]

I don't think it needs to block this particular PR, but is the subinterpreter work advanced enough that we can add an actual test that the module isolation worked yet?

I'm guessing the answer is no because we need to import datetime to get the timedeltas, and datetime is not isolated?

[erlend-aasland]

I don't think it needs to block this particular PR, but is the subinterpreter work advanced enough that we can add an actual test that the module isolation worked yet?

Subinterpreter testing is not optimal yet. There's some machinery in test_embed / Programs/_testembed.c. See also #98627. Thanks for bringing that up.

I'm guessing the answer is no because we need to import datetime to get the timedeltas, and datetime is not isolated?

Correct, _datetime is not isolated yet; I've got a fairly up to date proof-of-concept patch for it, though.

[erlend-aasland]

Thanks again for the reviews, Kumar and Paul; highly appreciated.