Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020: Add style improvements to solutions for Project Euler Problem 04 #2945

Merged
merged 22 commits into from Oct 7, 2020
Merged

Hacktoberfest 2020: Add style improvements to solutions for Project Euler Problem 04 #2945

merged 22 commits into from Oct 7, 2020
+4 −4

Conversation

@archaengel
Copy link
Contributor

@archaengel archaengel commented Oct 6, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related #2786
archaengel added 18 commits Oct 6, 2020
@archaengel
Fix typehints in project_euler/problem01
Loading status checks…
e70c27d 
Squashed commit of the following:

commit 6801d07
Author: Archaengel <god11341258@gmail.com>
Date:   Mon Oct 5 16:40:10 2020 -0700

    Fix typehints in project_euler/problem01

commit 29afc3a
Author: Archaengel <god11341258@gmail.com>
Date:   Mon Oct 5 15:06:34 2020 -0700

    Add typehints and default argument for project_euler/problem_01
@archaengel
Merge remote-tracking branch 'upstream/master' into master
cd03961
@archaengel
Merge remote-tracking branch 'upstream/master' into master
68c47af
@archaengel
Add default args, typehints, and expand variable names for PE prob 02
Loading status checks…
db03f25
@archaengel
Merge remote-tracking branch 'upstream/master' into master
07f1d9a
@archaengel
Merge remote-tracking branch 'upstream/master' into master
b3c97d3
@archaengel
Add style improvements for first solution of PE Problem 02
4c163d0
@archaengel
Add default arg and typehints for second solution of PE Problem 02
8c30a0c
@archaengel
Add default arg for third solution of PE Problem 02
a277101
@archaengel
Add style improvements for 1st soln of PE problem 03
f691938
@archaengel
Add default arg and typehints for 2nd soln of PE problem 03
f188b91
@archaengel
Add default arg for 3rd soln of PE problem 03
Loading status checks…
8053b0d
@archaengel
Remove unnecessary newlines
e4f8b0d
@archaengel
Merge branch 'improvement/problem03-code-style' into master
Loading status checks…
4d47ce8
@archaengel
Remove unnecessary newlines
Loading status checks…
7dcdf96
@archaengel
Fix end of file for 2nd soln in PE problem 03
Loading status checks…
66e26b1
@archaengel
Merge remote-tracking branch 'upstream/master' into master
5816b0c
@archaengel
Add style improvements to solutions for PE problem 04
Loading status checks…
621c6a2
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 7, 2020

Please don't remove newlines blindly. If they were already present let them be.
@archaengel
Copy link
Contributor Author

@archaengel archaengel commented Oct 7, 2020

Thanks for taking a look! I'll restore them.
@archaengel
archaengel reviewed Oct 7, 2020
View changes
project_euler/problem_04/sol1.py Outdated Show resolved Hide resolved
archaengel added 2 commits Oct 7, 2020
@archaengel
Restore original newlines in soln for PE problem 04
Loading status checks…
6dbaafa
@archaengel
Fix punctuation in docstring for PE problem 04
Loading status checks…
2ebfe8e
@dhruvmanila
dhruvmanila reviewed Oct 7, 2020
View changes
project_euler/problem_04/sol1.py Outdated Show resolved Hide resolved
@archaengel
Restore solution bodies for PE problem 04
Loading status checks…
ec76dc5
@archaengel archaengel changed the title Hacktoberfest 2020: Add style improvements to solutions for Project Euler Problem 04 Hacktoberfest 2020: Add type hints and default arguments to solutions for Project Euler Problem 04 Oct 7, 2020
@dhruvmanila
dhruvmanila reviewed Oct 7, 2020
View changes
project_euler/problem_04/sol2.py Outdated Show resolved Hide resolved
@archaengel
Expand variable names for 2nd soln of PE problem 04
Loading status checks…
f69539a
@archaengel archaengel changed the title Hacktoberfest 2020: Add type hints and default arguments to solutions for Project Euler Problem 04 Hacktoberfest 2020: Add style improvements to solutions for Project Euler Problem 04 Oct 7, 2020
@dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit a5000d3 into TheAlgorithms:master Oct 7, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@archaengel
Copy link
Contributor Author

@archaengel archaengel commented Oct 7, 2020

Thanks for taking the time to review!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@archaengel @dhruvmanila
You can’t perform that action at this time.