Skip to content

Ensure "topmost popover ancestor" is only called for auto or hint popovers#12493

Merged
zcorpan merged 2 commits into
mainfrom
jakearchibald/popover-manual-fix
May 28, 2026
Merged

Ensure "topmost popover ancestor" is only called for auto or hint popovers#12493
zcorpan merged 2 commits into
mainfrom
jakearchibald/popover-manual-fix

Conversation

@jakearchibald
Copy link
Copy Markdown
Collaborator

@jakearchibald jakearchibald commented May 27, 2026

Fixes #10988

No implementation changes needed.

Commit message:

Ensure "topmost popover ancestor" is only called for auto or hint popovers.

/popover.html ( diff )

@jakearchibald
Copy link
Copy Markdown
Collaborator Author

@mfreed7 can you give this a sanity check?

cc @annevk

Copy link
Copy Markdown
Collaborator

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks for the cleanup.

@zcorpan zcorpan merged commit 0092d0c into main May 28, 2026
2 checks passed
@zcorpan zcorpan deleted the jakearchibald/popover-manual-fix branch May 28, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

The topmost popover ancestor algorithm is used for manual popovers

3 participants