Skip to content

Address resolved feedback on temporalAuthResult struct#82

Closed
Copilot wants to merge 1 commit into
refactor-thand-notifierfrom
copilot/sub-pr-81
Closed

Address resolved feedback on temporalAuthResult struct#82
Copilot wants to merge 1 commit into
refactor-thand-notifierfrom
copilot/sub-pr-81

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 4, 2025

This PR addresses feedback from #81 regarding the temporalAuthResult struct in the Thand authorization workflow. The comment thread has been marked as resolved.

Current State

The temporalAuthResult struct already includes the AuthRequest field:

type temporalAuthResult struct {
	Index        int
	Identity     string
	AuthRequest  *models.AuthorizeRoleRequest  // Field exists
	AuthResponse *models.AuthorizeRoleResponse
	Err          error
}

The field is properly assigned when collecting results from parallel authorization tasks:

results[result.Index] = authResult{
	Identity:     result.Identity,
	AuthRequest:  result.AuthRequest,  // No compilation error
	AuthResponse: result.AuthResponse,
	Error:        result.Err,
}

No changes required - the feedback was addressed in the original implementation.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update notifier refactor and email templating based on feedback Address resolved feedback on temporalAuthResult struct Nov 4, 2025
Copilot AI requested a review from hughneale November 4, 2025 17:30
@hughneale hughneale closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants