Fix Temporal worker startup order

[hughneale]

Summary

Briefly describe what this PR does and why. Link to the relevant issue or context.

Closes #

---

Type of Change

• feat – New feature (minor version bump)
• fix – Bug fix (patch version bump)
• refactor – Code refactoring, no functional change
• docs – Documentation only
• test – Adding or updating tests
• chore – Build, CI, dependency updates
• major / BREAKING CHANGE – Breaking change (major version bump)

---

What Changed

A concise list of the changes made. Focus on the what and why, not the how.

---

Provider / Workflow / Role Changes

Complete this section if you've added or modified providers, workflows, or roles. Delete if not applicable.

Area	Change	Notes
Provider
Workflow
Role

• Provider config files updated (config/providers/)
• Role config files updated (config/roles/)
• Workflow definitions updated (config/workflows/)
• Example configs updated (examples/)

---

Security Considerations

This project handles privileged access. Describe any security implications of this change.

• No security impact
• Reviewed for least-privilege impact
• Access grant / revocation logic reviewed
• Audit trail is preserved for any new access paths
• No credentials, tokens, or secrets introduced in code or config

Security notes (if applicable):

---

Testing

Describe how this was tested. Include commands if helpful.

• Unit tests pass (go test ./...)
• Functional tests pass
• Integration tests pass
• Manually tested locally — describe scenario below

Manual test scenario (if applicable):

# Describe the steps taken to verify the change works end-to-end

---

Breaking Changes

If this is a breaking change, describe the impact and any migration steps required.

• This PR does not introduce breaking changes
• This PR does introduce breaking changes (describe below)

Migration steps (if applicable):

---

Documentation

• No documentation changes needed
• In-code comments updated
• docs/ updated
• README.md updated
• Config examples updated

---

Checklist

• My branch is up to date with main
• Commit messages follow the conventional commit format (feat:, fix:, major:, etc.)
• No debug code, hardcoded values, or temporary workarounds left in
• All new code has appropriate test coverage
• I have reviewed my own diff before requesting review

[Copilot]

Pull request overview

This PR adjusts Temporal initialization so workflows/activities are registered before any Temporal workers are started, preventing startup-order issues.

Changes:

• Added an explicit StartWorkers() lifecycle step to the Temporal service interface and implementation.
• Moved Temporal worker startup to occur after workflow/activity registration (and after provider initialization in server mode).
• Updated Temporal integration test setup to start workers after registration.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/integration/services/temporal_test.go	Starts Temporal workers after registering test workflow/activity.
internal/models/temporal.go	Extends Temporal service interface with StartWorkers().
internal/config/temporal.go	Uses servicesClient directly when registering Temporal workflows/activities.
internal/config/services/temporal/multi_worker.go	Updates lifecycle comment to reflect new StartWorkers() step.
internal/config/services/temporal/main.go	Splits worker creation vs startup; adds worker-start tracking/state.
internal/config/services.go	Makes Temporal setup run during service initialization; adds StartTemporalWorkers().
internal/config/providers.go	Ensures services are initialized earlier (server mode) and starts Temporal workers after providers init.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.