assert.InDeltaSlice: fix lack of length mismatch handling#1896
Open
puneetdixit200 wants to merge 2 commits into
Open
assert.InDeltaSlice: fix lack of length mismatch handling#1896puneetdixit200 wants to merge 2 commits into
puneetdixit200 wants to merge 2 commits into
Conversation
dolmen
requested changes
May 24, 2026
Author
|
Updated in f402eee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1263.
InDeltaSlicealready compares values by index, but it did not first verify that the two slices had the same length. That meant extra expected values were ignored, while extra actual values could panic by indexing past the expected slice.This adds an explicit length check before the element-wise comparison. I also added regression coverage for both mismatch directions.
Verification:
go test ./assert -run TestInDeltaSlice -count=1failed before the fix: the shorter actual slice passed and the longer actual slice panicked withreflect: slice index out of rangego test ./assert -run TestInDeltaSlice -count=1go test ./assert -count=1go test ./... -count=1go vet ./...gofmt -w assert/assertions.go assert/assertions_test.gogit diff --check