Skip to content

feat(terminal): restrict default allowed commands to 'ls' and 'echo' #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RonithManikonda wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(terminal): restrict default allowed commands to 'ls' and 'echo' #372

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd8c5fc
feat(terminal): restrict default allowed commands to 'ls' and 'echo'
RonithManikonda Oct 13, 2024
8ba09bd
test(terminal): update tests to align with default command behavior
RonithManikonda Oct 31, 2024
bb85dca
docs: keep backticks
AriPerkkio Nov 1, 2024
9f8a8d2
Merge branch 'main' into ronith/hide-toggle-terminal-button
AriPerkkio Nov 1, 2024
b5a30fb
Update packages/runtime/src/webcontainer/terminal-config.spec.ts
RonithManikonda Nov 5, 2024
69ec710
Update packages/runtime/src/webcontainer/terminal-config.ts
RonithManikonda Nov 5, 2024
8d0a095
feat(terminal): restrict default allowed commands to 'ls' and 'echo'
RonithManikonda Jan 15, 2025
43c24c4
Merge branch 'main' into ronith/hide-toggle-terminal-button
AriPerkkio Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(terminal): update tests to align with default command behavior 
adjust tests to expect ['ls', 'echo'] as default allowCommands when undefined, aligning tests with updated functionality

closes #302
  • Loading branch information
@RonithManikonda
RonithManikonda committed Oct 31, 2024
commit 8ba09bd809f671b8aea70c55585a8803f514100c
10 changes: 5 additions & 5 deletions packages/runtime/src/webcontainer/terminal-config.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ describe('TerminalConfig', () => {
expect(config.panels[0].id).toBe('foo');
expect(config.panels[0].processOptions).toEqual({
allowRedirects: false,
allowCommands: undefined,
allowCommands: ['ls', 'echo'],
});
expect(config.panels[1].title).toBe('Bar');
expect(config.panels[1].id).toBe('bar');
expect(config.panels[1].processOptions).toEqual({
allowRedirects: false,
allowCommands: undefined,
allowCommands: ['ls', 'echo'],
});
});

Expand Down Expand Up @@ -144,13 +144,13 @@ describe('TerminalConfig', () => {
expect(config.panels[0].title).toBe('TERM 1');
expect(config.panels[0].processOptions).toEqual({
allowRedirects: true,
allowCommands: ['echo'],
allowCommands: ['ls', 'echo'],
Comment thread
RonithManikonda marked this conversation as resolved.
Outdated
});

expect(config.panels[1].title).toBe('TERM 2');
expect(config.panels[1].processOptions).toEqual({
allowRedirects: true,
allowCommands: ['echo'],
allowCommands: ['ls', 'echo'],
});

expect(config.panels[2].title).toBe('OUT');
Expand All @@ -171,7 +171,7 @@ describe('TerminalConfig', () => {
expect(config.panels[0].title).toBe('TERM 1');
expect(config.panels[0].processOptions).toEqual({
allowRedirects: false,
allowCommands: ['echo'],
allowCommands: ['ls', 'echo'],
});

expect(config.panels[1].title).toBe('TERM 2');
Expand Down