fix: Use CMAKE_SHARED_LIBRARY_SUFFIX instead of hardcode .so#762
Merged
Conversation
Contributor
|
Can you rebase on |
Contributor
Author
Done |
macOS uses .dylib and this is the only thing that prevents using CMake on macOS.
Contributor
|
Nice. We could add CMake builds in CI for both Linux and Mac when this is merged then. |
jschlyter
approved these changes
Nov 29, 2024
Contributor
Author
|
Thanks, I wasn't expecting this quick merge actually. There is another thing that is not helping with macOS (and probably Linux as well). But let me put that in another PR. |
Contributor
Author
|
Never mind, I guess I am just running into the issue that The reporter created some alternative you might want to add. Anyways, this is now how I configure: cmake -H. -Bbuild \
-DCMAKE_INSTALL_PREFIX=$INSTALL_DIR \
-DCMAKE_INSTALL_SYSCONFDIR=$INSTALL_DIR/etc \
-DCMAKE_INSTALL_LOCALSTATEDIR=$INSTALL_DIR/var |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS uses .dylib and this is the only thing that prevents using CMake on macOS.