Skip to content

Fixes AES secret key import failing on newline characters#747

Merged
jschlyter merged 1 commit into
softhsm:developfrom
ijsf:fix_aes_import
Dec 2, 2024
Merged

Fixes AES secret key import failing on newline characters#747
jschlyter merged 1 commit into
softhsm:developfrom
ijsf:fix_aes_import

Conversation

@ijsf
Copy link
Copy Markdown
Contributor

@ijsf ijsf commented Apr 30, 2024

Fix for issue #746.

Also removes the need for NULL termination since we are dealing with binary data.

@jschlyter
Copy link
Copy Markdown
Contributor

Please rebase on develop and mark as ready when ready.

@ijsf ijsf marked this pull request as ready for review November 29, 2024 17:17
@ijsf ijsf requested a review from a team as a code owner November 29, 2024 17:17
@jschlyter jschlyter requested a review from bjosv November 29, 2024 18:15
Copy link
Copy Markdown
Contributor

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/bin/util/softhsm2-util-botan.cpp
@jschlyter jschlyter merged commit 6d75f15 into softhsm:develop Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants