Add misc derivations#571
Merged
Merged
Conversation
Aearsis
suggested changes
Aug 26, 2020
f1dfd28 to
5f3ace8
Compare
Signed-off-by: realmfoo <konstantin.leboev@gmail.com>
Signed-off-by: realmfoo <konstantin.leboev@gmail.com>
Signed-off-by: realmfoo <konstantin.leboev@gmail.com>
…AND_KEY Added tests for CKA_EXTRACTABLE and CKA_SENSITIVE attributes. Signed-off-by: realmfoo <konstantin.leboev@gmail.com>
5f3ace8 to
b0f12e1
Compare
Contributor
Author
|
@Aearsis please let me know if you need any additional actions from my end... |
Contributor
Contributor
|
Thanks for the contribution, I reviewed the code, it looks good to me. Asking @halderen if he concurs, and if so, to merge it into |
Contributor
|
Reviewed and contains the checks regarding the sensitive and extractable attributes, that are absolutely needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added derive support with CKM_CONCATENATE_DATA_AND_BASE, CKM_CONCATENATE_BASE_AND_DATA and CKM_CONCATENATE_BASE_AND_KEY.