Skip to content

Add wrap support with CKM_AES_CBC#445

Merged
halderen merged 3 commits into
softhsm:developfrom
martinpaljak:wrap-with-aes-cbc
Mar 3, 2020
Merged

Add wrap support with CKM_AES_CBC#445
halderen merged 3 commits into
softhsm:developfrom
martinpaljak:wrap-with-aes-cbc

Conversation

@martinpaljak
Copy link
Copy Markdown
Contributor

No description provided.

@rijswijk
Copy link
Copy Markdown
Contributor

rijswijk commented Feb 8, 2019

Hi Martin, thank you for your contribution. We have a couple of requests before we can merge the pull requests:

  • Can you also ensure that unwrapping is supported? It seems that the current code is only for wrapping. This is because we would prefer to keep the mechanism support complete.

  • Can you also write testcases to check that the mechanism works correctly? You can simply extend the SymmetricAlgorithmTests in src/lib/test

Thanks!

@martinpaljak
Copy link
Copy Markdown
Contributor Author

Will look into it when time permits.

@martinpaljak
Copy link
Copy Markdown
Contributor Author

FYI: I've generalized this to add unwrap support "the proper way" (not in softhsm2.cpp but only for openssl aes driver) and extended to support the same for 3des. Not sure if I ever get to writing tests, as I test via Java.

Also, added not-so-nice-looking support for CKM_[XOR|CONCATENATE]_* that should probably be added as a separate PR...

@halderen halderen added this to the 2.6.0 milestone Feb 27, 2020
@halderen halderen merged commit b50ad17 into softhsm:develop Mar 3, 2020
@syarul syarul mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants