improvement(apollo): align tools and block with Apollo API docs#4487
improvement(apollo): align tools and block with Apollo API docs#4487waleedlatif1 wants to merge 19 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Several tools change request/response contracts: bulk create/update endpoints now accept richer payloads (incl. dedupe/labels, uniform updates, async jobs), people/org enrich add webhook-based phone reveal and revised outputs, opportunity search switches to a GET+querystring model, and sequence/task endpoints are updated for required send-from email account + new response shapes. The Apollo block adds corresponding UI fields, improves JSON parsing/mapping (incl. splitting bulk update inputs), and a migration map preserves prior subblock parameter IDs. Reviewed by Cursor Bugbot for commit 78407fd. Configure here. |
Greptile SummaryThis PR aligns 25 Apollo tools and the block with the official Apollo API documentation, fixing endpoint paths, field names, and response shapes across all operations. Guard logic and runtime validations from previous review rounds are now in place.
Confidence Score: 5/5Safe to merge — all previously identified issues have been addressed in follow-up commits and no new defects were found. All 25 tools and the block have been audited. The guard logic in bulk-update tools correctly covers every invalid input combination. Sub-block migrations cover all renamed fields. The sequence_add and task_create endpoints now match the Apollo API contract. No new runtime errors or silent data drops were found. No files require special attention. Important Files Changed
Reviews (11): Last reviewed commit: "docs" | Re-trigger Greptile |
e59ab46 to
7447852
Compare
|
@greptile |
|
@cursor review |
|
bugbot run |
|
@cursor review |
|
@greptile |
|
@greptile |
|
@cursor review |
…ation, expose account_bulk_create options
|
@greptile |
|
@cursor review |
…lify task_create created flag
|
@greptile |
|
@cursor review |
…igrate note→task_notes
Final pass over the Apollo integration after a per-tool forensic audit
against Apollo.io docs. Notable fixes:
- organization_enrich: GET+querystring -> POST+JSON body (canonical, non
master-key)
- organization_bulk_enrich: ?domains[]= -> JSON body { organizations }
- people_search: declare/forward organization_num_employees_ranges; fix
contact_email_status placeholder ("likely to engage", with spaces)
- account_bulk_create: surface failed_accounts and failed count
- contact_bulk_create: expand documented per-contact fields (CRM IDs,
phone_numbers, contact_emails, typed_custom_fields, etc.)
- sequence_add_contacts: surface remaining documented filter params
- task_create: confirm wire field name (note) and remap from task_notes
- types: tighten params/responses for the above
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 78407fd. Configure here.
| close_date: 'closed_date', | ||
| stage_id: 'opportunity_stage_id', | ||
| note: 'task_notes', | ||
| }, |
There was a problem hiding this comment.
Missing subblock migration for account website_url to domain
Medium Severity
The website_url subBlock for account_create and account_update operations was replaced with domain, but no migration entry was added to SUBBLOCK_ID_MIGRATIONS. Existing saved workflows that stored a website_url value for account operations will silently lose that data — the old value remains as an orphaned key while the new domain subBlock starts empty. Other renamed fields like close_date, stage_id, and note all have migration entries, but website_url does not.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 78407fd. Configure here.
| close_date: 'closed_date', | ||
| stage_id: 'opportunity_stage_id', | ||
| note: 'task_notes', | ||
| }, |
There was a problem hiding this comment.
Removed opportunity/task subBlocks lack migration cleanup entries
Low Severity
Several subBlock IDs were removed without _removed_* migration entries: description (opportunity create/update), account_ids/stage_ids/owner_ids (opportunity search), q_keywords (opportunity/account search), contact_id/account_id (task create), completed (task search), and active (sequence search). Existing workflows retain these orphaned values in state, and those values silently pass through parsedParams to tool body functions that no longer use them. The ashby block follows the _removed_* pattern for this exact scenario.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 78407fd. Configure here.
Summary
Type of Change
Testing
Tested manually. Lint and typecheck pass.
Checklist