Skip to content

feat: 微信小程序-小程序链接#833

Merged
silenceper merged 2 commits into
silenceper:v2from
markwang1992:mini-url
May 1, 2025
Merged

feat: 微信小程序-小程序链接#833
silenceper merged 2 commits into
silenceper:v2from
markwang1992:mini-url

Conversation

@markwang1992
Copy link
Copy Markdown
Contributor

No description provided.

@silenceper silenceper requested a review from Copilot April 30, 2025 03:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new features for WeChat Mini Program links by adding support for generating and querying different types of URL schemes. Key changes include:

  • Introducing a new constant block for URL scheme generation, including NFC-specific endpoints.
  • Updating the USParams and ResQueryScheme structures to support additional parameters, with new fields for model identification and serial numbers.
  • Adding a new query interface for URL links in a separate module.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
miniprogram/urlscheme/urlscheme.go Added NFC URL scheme generation and updated request parameters
miniprogram/urlscheme/query.go Introduced QuerySchemeWithRes and new QuotaInfo type for scheme queries
miniprogram/urllink/query.go Revised URL link query to include access token in the endpoint and added a new ULQueryRequest type
Comments suppressed due to low confidence (2)

miniprogram/urlscheme/urlscheme.go:64

  • [nitpick] The field 'Sn' is ambiguous; consider renaming it to a more descriptive identifier (e.g., 'serialNumber') to improve clarity.
Sn             string      `json:"sn,omitempty"`

miniprogram/urllink/query.go:41

  • The QuotaInfo type is defined in both 'urlscheme/query.go' and 'urllink/query.go'; consider consolidating this definition into a shared module to reduce duplication.
type QuotaInfo struct { RemainVisitQuota int64 `json:"remain_visit_quota"` }

@houseme
Copy link
Copy Markdown
Collaborator

houseme commented Apr 30, 2025

LGTM

@houseme houseme requested review from houseme and silenceper April 30, 2025 14:19
@silenceper silenceper merged commit dd43b7b into silenceper:v2 May 1, 2025
13 checks passed
@markwang1992 markwang1992 deleted the mini-url branch January 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants