feat: 微信小程序-小程序链接#833
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new features for WeChat Mini Program links by adding support for generating and querying different types of URL schemes. Key changes include:
- Introducing a new constant block for URL scheme generation, including NFC-specific endpoints.
- Updating the USParams and ResQueryScheme structures to support additional parameters, with new fields for model identification and serial numbers.
- Adding a new query interface for URL links in a separate module.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| miniprogram/urlscheme/urlscheme.go | Added NFC URL scheme generation and updated request parameters |
| miniprogram/urlscheme/query.go | Introduced QuerySchemeWithRes and new QuotaInfo type for scheme queries |
| miniprogram/urllink/query.go | Revised URL link query to include access token in the endpoint and added a new ULQueryRequest type |
Comments suppressed due to low confidence (2)
miniprogram/urlscheme/urlscheme.go:64
- [nitpick] The field 'Sn' is ambiguous; consider renaming it to a more descriptive identifier (e.g., 'serialNumber') to improve clarity.
Sn string `json:"sn,omitempty"`
miniprogram/urllink/query.go:41
- The QuotaInfo type is defined in both 'urlscheme/query.go' and 'urllink/query.go'; consider consolidating this definition into a shared module to reduce duplication.
type QuotaInfo struct { RemainVisitQuota int64 `json:"remain_visit_quota"` }
Collaborator
|
LGTM |
houseme
approved these changes
Apr 30, 2025
silenceper
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.