Skip to content

ReadBufferDataHandle: fixed calculating local offset #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trnila wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ReadBufferDataHandle: fixed calculating local offset #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ReadBufferDataHandle: fixed calculating local offset 
offset should not be cast to int before modulo operation
  • Loading branch information
@trnila
trnila committed Jan 6, 2020
commit d3d14176cadb06c026d8964cbb034eff4226d78b
2 changes: 1 addition & 1 deletion src/main/java/org/scijava/io/handle/ReadBufferDataHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ private byte[] readPage(final int pageID, final int slotID) throws IOException {
* Calculates the offset in the current page for the given global offset
*/
private int globalToLocalOffset(final long off) {
return (int) off % pageSize;
return (int) (off % pageSize);
}

@Override
Expand Down