Skip to content

Support PyPy _pickle accelerator in bm_pickle#461

Merged
StanFromIreland merged 2 commits intopython:mainfrom
mattip:pypy
May 6, 2026
Merged

Support PyPy _pickle accelerator in bm_pickle#461
StanFromIreland merged 2 commits intopython:mainfrom
mattip:pypy

Conversation

@mattip
Copy link
Copy Markdown
Contributor

@mattip mattip commented Mar 31, 2026

I am working on adding a _pickle RPython implementation to PyPy. I ran into a problem where the current benchmark will ignore that possibility and will always use the pure-python version on PyPy. This PR makes the logic work for the case that PyPy does have a _pickle module and, like CPython, it is activated by default, but retains backward compatibility.

@StanFromIreland StanFromIreland changed the title adjust pure_python check for option that PyPy might have _pickle Support PyPy _pickle accelerator in bm_pickle May 6, 2026
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland merged commit 464210c into python:main May 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants