Skip to content

Refactor parse_xml function to handle external target references (Issue #1349) #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
al-rahul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor parse_xml function to handle external target references (Issue #1349) #1350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactor parse_xml function to handle external target references in C… 
…T_Relationship class
  • Loading branch information
@al-rahul
al-rahul committed Feb 29, 2024
commit 4ebb3aceee70cf3fe1c42c1b4a911875c2086050
5 changes: 4 additions & 1 deletion src/docx/opc/oxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
# ===========================================================================


def parse_xml(text: str) -> etree._Element: # pyright: ignore[reportPrivateUsage]
# pyright: ignore[reportPrivateUsage]
def parse_xml(text: str) -> etree._Element:
"""`etree.fromstring()` replacement that uses oxml parser."""
return etree.fromstring(text, oxml_parser)

Expand Down Expand Up @@ -170,6 +171,8 @@ def target_mode(self):

Defaults to ``Internal``.
"""
if self.target_ref and self.target_ref.startswith("#"):
return RTM.EXTERNAL
return self.get("TargetMode", RTM.INTERNAL)


Expand Down