Fix GH-22167: reject out-of-range SOAP schema integers#22178
Fix GH-22167: reject out-of-range SOAP schema integers#22178LamentXU123 wants to merge 2 commits into
Conversation
|
High level note ; I'd target master rather than 8.4. It's a correct change, but it turns input that currently parses (silently truncated by atoi) into a fatal SOAP-ERROR, so a WSDL |
This is rather like a new feature than a bug fix, we have lots of similar fixes before (i.e. rejecting NUL bytes in some functions) targeting the master branch so this should be targeting it too. |
|
take your time I ll (re)review it saturday at earliest. |
Fixed #22167
I also add logic to deal with numeric-strings. Now, both
2147483648and2147483648abcwill not be accepted (also added tests). Other behaviors remain the same.I don't sure if we can write the helper function in simpler ways using existing Zend API.