Remove PKCS11 single thread lock (#264)#277
Merged
Merged
Conversation
7d3f848 to
d2ab124
Compare
hug-dev
approved these changes
Oct 22, 2020
Member
hug-dev
left a comment
There was a problem hiding this comment.
Nice, that's egg-cellent 🥚
I agree to merge it once you have the CI passing 🚋
44aa418 to
4255a98
Compare
hug-dev
approved these changes
Oct 22, 2020
|
|
||
| RUN cd SoftHSMv2 \ | ||
| && sh autogen.sh \ | ||
| || sh autogen.sh |
Member
There was a problem hiding this comment.
Would be nice to link with the bug description as a comment here for an external eye to understand why this was needed
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
4255a98 to
3c7afeb
Compare
hug-dev
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the mutex that was used to force the PKCS11 provider
to work in a single-threaded way. The issue was fixed in
softhsm/SoftHSMv2#576 and our Dockerfiles
have been updated to use that commit.
Fixes #264