Skip to content

http: validate headers in writeEarlyHints #61897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 2, 2026
+52 −2
Merged

http: validate headers in writeEarlyHints #61897

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79bd80c
http: validate headers in writeEarlyHints
rsclarke Feb 20, 2026
dc05fe1
test: fix lint errors in test-http-early-hints-invalid-argument
rsclarke Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix lint errors in test-http-early-hints-invalid-argument
  • Loading branch information
@rsclarke
rsclarke committed Feb 24, 2026
commit dc05fe1b05a8dff84f22f2f214efdb8dbc095f10
4 changes: 2 additions & 2 deletions test/parallel/test-http-early-hints-invalid-argument.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ const testResBody = 'response content\n';

assert.throws(() => {
res.writeEarlyHints({
link: '</styles.css>; rel=preload; as=style',
'link': '</styles.css>; rel=preload; as=style',
'X-Custom': 'valid\r\nSet-Cookie: session=evil',
});
}, (err) => err.code === 'ERR_INVALID_CHAR');

assert.throws(() => {
res.writeEarlyHints({
link: '</styles.css>; rel=preload; as=style',
'link': '</styles.css>; rel=preload; as=style',
'X-Custom\r\nSet-Cookie: session=evil': 'value',
});
}, (err) => err.code === 'ERR_INVALID_HTTP_TOKEN');
Expand Down
Loading