Skip to content

lib: include ESM loader in the built-in snapshot #61769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 7 commits into from
Closed

lib: include ESM loader in the built-in snapshot #61769

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa8161a
test: allow filtering async internal frames in assertSnapshot
joyeecheung Feb 13, 2026
92d6e40
lib: remove top-level getOptionValue() calls in lib/internal/modules
joyeecheung Feb 6, 2026
d00eeec
lib: reduce cycles in esm loader and load it in snapshot
joyeecheung Feb 6, 2026
9cd87a2
benchmark: add startup benchmark for ESM entrypoint
joyeecheung Feb 6, 2026
f33117a
fixup! test: allow filtering async internal frames in assertSnapshot
joyeecheung Feb 14, 2026
21bdb3d
fixup! test: allow filtering async internal frames in assertSnapshot
joyeecheung Feb 15, 2026
cdf427a
fixup! lib: reduce cycles in esm loader and load it in snapshot
joyeecheung Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test: allow filtering async internal frames in assertSnapshot
  • Loading branch information
@joyeecheung
joyeecheung committed Feb 14, 2026
commit f33117a7a07897e64f9ecaf5dc4e97e06203826d
2 changes: 1 addition & 1 deletion test/common/assertSnapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const { hostname } = require('node:os');
* Group 6: Line end (including color codes and `{` which indicates the start of an error object details)
*/
// Mappings: (g1 ) (g2 ) (g3 ) (g4 ) (g5 ) (g6 )
const internalStackFramesRegexp = /(?<=\n)(\s*(?:\x1b?\[\d+m\s+)?at\s+)(?:async\s+)?(?:(.+?)\s+\()?(?:(node:.+?):(\d+)(?::(\d+))?)\)?((?:\x1b?\[\d+m)?\s*{?\n|$)/g;
const internalStackFramesRegexp = /(?<=\n)(\s*(?:\x1b?\[\d+m\s+)?(?:at\s+)?)?(?:async\s+)?(?:(.+?)\s+\()?(?:(node:.+?):(\d+)(?::(\d+))?)\)?((?:\x1b?\[\d+m)?\s*{?\n|$)/g;
Comment thread
joyeecheung marked this conversation as resolved.
Outdated
/**
* Group 1: Filename
* Group 2: Line number
Expand Down
Loading