bin: use --no-mailmap when loading commits#148
Open
mcollina wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
aduh95
reviewed
May 28, 2026
Comment on lines
+401
to
+410
| const defaultShow = git(repoDir, ['show', '--quiet', '--format=medium', 'HEAD']) | ||
| const rawShow = git(repoDir, ['show', '--no-mailmap', '--quiet', '--format=medium', 'HEAD']) | ||
|
|
||
| tt.match(defaultShow, | ||
| /Author:\s+Matteo Collina <matteo\.collina@gmail\.com>/, | ||
| 'git show applies mailmap by default') | ||
| tt.match(rawShow, | ||
| /Author:\s+Matteo Collina <hello@matteocollina\.com>/, | ||
| 'git show --no-mailmap preserves the raw author email') | ||
|
|
Contributor
There was a problem hiding this comment.
This would make the test fail for unrelated reasons (e.g if the git global config disables mailmaps)
aduh95
reviewed
May 28, 2026
Comment on lines
+377
to
+387
| const repoDir = mkdtempSync(join(tmpdir(), 'core-validate-commit-')) | ||
| const env = { | ||
| GIT_AUTHOR_NAME: 'Matteo Collina', | ||
| GIT_AUTHOR_EMAIL: 'hello@matteocollina.com', | ||
| GIT_COMMITTER_NAME: 'Matteo Collina', | ||
| GIT_COMMITTER_EMAIL: 'hello@matteocollina.com' | ||
| } | ||
|
|
||
| git(repoDir, ['init', '-b', 'main']) | ||
| git(repoDir, ['config', 'user.name', 'Test User']) | ||
| git(repoDir, ['config', 'user.email', 'test@example.com']) |
Contributor
There was a problem hiding this comment.
Can we instead use this repo like is done for the other tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git show --no-mailmapso validation uses the raw commit authorSigned-off-bymismatch warnings caused by.mailmaprewritingTesting