Work with go1.13 by simply deleting explicit flag parsing#5398
Merged
Conversation
Contributor
Author
|
/uncc @markusthoemmes |
e186d5a to
8e501e3
Compare
Contributor
Author
|
/cc @vagababov |
adrcunha
approved these changes
Sep 5, 2019
Contributor
Author
|
/retest
…On Thu, Sep 5, 2019 at 1:31 PM Knative Prow Robot ***@***.***> wrote:
@chaodaiG <https://github.com/chaodaiG>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-knative-serving-unit-tests 7e5ae57
<7e5ae57>
link
<https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_serving/5398/pull-knative-serving-unit-tests/1169708306525065216> /test
pull-knative-serving-unit-tests
Full PR test history
<https://gubernator.knative.dev/pr/knative_serving/5398>. Your PR
dashboard <https://gubernator.knative.dev/pr/chaodaiG>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5398?email_source=notifications&email_token=AKXNDYPZRPJAIXTIMWKV42LQIFUBLA5CNFSM4ITXSMOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AVETI#issuecomment-528568909>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKXNDYLQNPPHUHE6KZK6U4LQIFUBLANCNFSM4ITXSMOA>
.
|
|
The following jobs failed due to test flakiness:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests: and 3 more. |
Contributor
Author
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, chaodaiG, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 6, 2019
Merged
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 25, 2019
In #5398 we missed that flags cannot be set until after they are parsed. As golang/testing is now doing the parsing just before calling our test function, to change values they must now be called during the test (or before if we were to use TestMain -- a future improvement planned). So split the flag setup into definition and value setting, then call it in the tests that use ServingFlags. The actual flag reading/parsing has been put into pkg: knative/pkg#870
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go testwith any flag failed to work with go.1.13, as reported in knative/test-infra#1329. The root cause is testing level flags (i.e.-v) are registered intesting.Init()according to release note as part of generatedmain()function, which is executed later than global variable initialization, such asinitializeServingFlagscall, which failed to parse flags as they are not registered yet.Deleting
flag.Parse()frominitializeServingFlagsseems not affecting flags parsing in both go1.12 and go1.13, in the latter it's done viatesting.Init(). And in go1.12 it also works as the execution order is:initializeServingFlags->testing.M.Run (where flag.Parse is invoked implicitly)->Running each individual testFixes knative/test-infra#1329