Skip to content

fix: Backlog never zero despite messages received #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpcollins-google merged 1 commit into from
Aug 3, 2021
Merged

fix: Backlog never zero despite messages received #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/pubsublite/cloudpubsub/internal/ack_set_tracker_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async def ack(self, offset: int):
if receipt == ack:
prefix_acked_offset = receipt
continue
self._receipts.append(receipt)
self._receipts.appendleft(receipt)
self._acks.put(ack)
break
if prefix_acked_offset is None:
Expand Down
10 changes: 6 additions & 4 deletions tests/unit/pubsublite/cloudpubsub/internal/ack_set_tracker_impl_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,17 @@ async def test_track_and_aggregate_acks(committer, tracker: AckSetTracker):
committer.commit.assert_has_calls([])
await tracker.ack(offset=3)
committer.commit.assert_has_calls([])
await tracker.ack(offset=5)
committer.commit.assert_has_calls([])
await tracker.ack(offset=1)
committer.commit.assert_has_calls([call(Cursor(offset=6))])
committer.commit.assert_has_calls([call(Cursor(offset=4))])
await tracker.ack(offset=5)
committer.commit.assert_has_calls(
[call(Cursor(offset=4)), call(Cursor(offset=6))]
)

tracker.track(offset=8)
await tracker.ack(offset=7)
committer.commit.assert_has_calls(
[call(Cursor(offset=6)), call(Cursor(offset=8))]
[call(Cursor(offset=4)), call(Cursor(offset=6)), call(Cursor(offset=8))]
)
committer.__aexit__.assert_called_once()

Expand Down