Implement admin client.#17
Merged
Merged
Conversation
Also small fix to retrying connection so it doesn't leak reads/writes from previous connections.
…nments. Also slightly change the semantics of PermanentFailable to not fail a RetryingConnection on retryable errors from a watched awaitable.
This handles aggregating flow control requests without allowing them to get above the max int64 value.
…age processing. Also ensure all asynchronous loopers are torn down when their underlying objects are.
…ns in a given region.
pradn
approved these changes
Sep 15, 2020
| if len(splits) != 3 or len(splits[2]) != 1: | ||
| raise InvalidArgument("Invalid zone name: " + to_parse) | ||
| region = CloudRegion(name=splits[0] + '-' + splits[1]) | ||
| return CloudZone(region, zone_id=splits[2]) |
There was a problem hiding this comment.
nit: consider checking splits[2] is a number
Contributor
Author
There was a problem hiding this comment.
Nack. splits[2] is not a number, it is a single lowercase character. 'us-central1-a' for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.