Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

feat: mark agent.default_language_code as required#116

Closed
gcf-owl-bot[bot] wants to merge 4 commits into
masterfrom
owl-bot-88d0e20a-a87e-42c3-8cf5-1d65dc33742d
Closed

feat: mark agent.default_language_code as required#116
gcf-owl-bot[bot] wants to merge 4 commits into
masterfrom
owl-bot-88d0e20a-a87e-42c3-8cf5-1d65dc33742d

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Jun 22, 2021 •
edited by parthea
Loading

PiperOrigin-RevId: 380726996

Source-Link: googleapis/googleapis@a5cec0a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/1e4922a1a812a78ebf324213df2ae079623020cb

feat: add return_partial response to Fulfillment
docs: add notes to train agent before sending queries

@gcf-owl-bot
feat!: mark agent.default_language_code as required feat: add return_…
aa433f0 
…partial response to Fulfillment docs: add notes to train agent before sending queries

PiperOrigin-RevId: 380726996

Source-Link: googleapis/googleapis@a5cec0a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/1e4922a1a812a78ebf324213df2ae079623020cb
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team June 22, 2021 04:47
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@product-auto-label product-auto-label Bot added the api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. label Jun 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2021
@parthea parthea changed the title feat!: mark agent.default_language_code as required feat: add return_partial response to Fulfillment docs: add notes to train agent before sending queries feat: mark agent.default_language_code as required Jun 23, 2021
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 23, 2021
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Jun 23, 2021

Logic that enforces the default_language_code parameter is already present on the backend so this is not expected to be a breaking change.

@busunkim96 busunkim96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2021
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 27, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2021
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Jun 30, 2021

Superseded by #119

@parthea parthea closed this Jun 30, 2021
@parthea parthea reopened this Jun 30, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2021
@parthea parthea closed this Jun 30, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @busunkim96 @yoshi-kokoro