feat: add schema revision samples by feywind · Pull Request #1870 · googleapis/nodejs-pubsub

feywind · 2024-01-05T19:23:28Z

This adds support for easily getting a schema gapic client, along with samples for schema revisions.

…ples

snippet-bot · 2024-01-05T19:23:35Z

Here is the summary of changes.

You are about to add 18 region tags.

samples/commitAvroSchema.js:32, tag pubsub_commit_avro_schema
samples/commitProtoSchema.js:32, tag pubsub_commit_proto_schema
samples/createTopicWithSchemaRevisions.js:32, tag pubsub_create_topic_with_schema_revisions
samples/deleteSchemaRevision.js:32, tag pubsub_delete_schema_revision
samples/getSchemaRevision.js:32, tag pubsub_get_schema_revision
samples/listSchemaRevisions.js:32, tag pubsub_list_schema_revisions
samples/listenForAvroRecordsWithRevisions.js:32, tag pubsub_subscribe_avro_records_with_revisions
samples/rollbackSchema.js:32, tag pubsub_rollback_schema
samples/typescript/commitAvroSchema.ts:28, tag pubsub_commit_avro_schema
samples/typescript/commitProtoSchema.ts:28, tag pubsub_commit_proto_schema
samples/typescript/createTopicWithSchemaRevisions.ts:28, tag pubsub_create_topic_with_schema_revisions
samples/typescript/deleteSchemaRevision.ts:28, tag pubsub_delete_schema_revision
samples/typescript/getSchemaRevision.ts:28, tag pubsub_get_schema_revision
samples/typescript/listSchemaRevisions.ts:28, tag pubsub_list_schema_revisions
samples/typescript/listenForAvroRecordsWithRevisions.ts:28, tag pubsub_subscribe_avro_records_with_revisions
samples/typescript/rollbackSchema.ts:28, tag pubsub_rollback_schema
samples/typescript/updateTopicSchema.ts:28, tag pubsub_update_topic_schema
samples/updateTopicSchema.js:32, tag pubsub_update_topic_schema

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

…c client

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…pubsub into schema-revisions

generated-files-bot · 2024-01-10T20:15:51Z

Warning: This pull request is touching the following templated files:

README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

…nodejs-pubsub into schema-revisions

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…nodejs-pubsub into schema-revisions

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

hongalex

These samples look good. I think there are a few missing ones,most important is probably pubsub_get_schema_revision but also pubsub_commit_proto_schema and pubsub_subscribe_avro_records_with_revisions. The first two should probably go in this PR, while the latter two can be in a separate PR?

…nodejs-pubsub into schema-revisions

feywind · 2024-01-22T17:27:54Z

These samples look good. I think there are a few missing ones,most important is probably pubsub_get_schema_revision but also pubsub_commit_proto_schema and pubsub_subscribe_avro_records_with_revisions. The first two should probably go in this PR, while the latter two can be in a separate PR?

Hmm, those didn't make it into my hotlist. I'll just add them in this PR.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…nodejs-pubsub into schema-revisions

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feywind added 3 commits January 5, 2024 12:44

feat: finish adding new methods to Schema wrapper

0fe2de1

feat: more updates for the schema update APIs, and a bunch of new sam…

a2f1b10

…ples

build: leave out samples/build/ from git checking

d522c86

feywind requested review from a team January 5, 2024 19:23

product-auto-label Bot added the size: l Pull request size is large. label Jan 5, 2024

Merge branch 'main' into schema-revisions

b98ac41

product-auto-label Bot added api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Jan 5, 2024

feywind added 3 commits January 8, 2024 15:48

feat: remove added veneer for schema revisions

a469b41

feat: make getSchemaClient() public so users can easily create a gapi…

215c3aa

…c client

samples: update samples for latest changes

d34044f

feywind changed the title ~~feat: add schema revision wrappers and new samples~~ feat: add schema revision samples Jan 8, 2024

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024

feywind and others added 4 commits January 8, 2024 16:48

docs: fix mismatched sample tags

a77cd9a

🦉 Updates from OwlBot post-processor

50f5b07

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'schema-revisions' of https://github.com/feywind/nodejs-…

007ee05

…pubsub into schema-revisions

tests: add more system tests for new schema samples

6b4786b

samples: add listSchemaRevisions sample

1f7600b

product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 10, 2024

Merge branch 'main' into schema-revisions

c678e34

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024

feywind and others added 3 commits January 10, 2024 15:37

samples: mismatched end tag

9865a1f

chore: merge branch 'schema-revisions' of https://github.com/feywind/…

c725972

…nodejs-pubsub into schema-revisions

🦉 Updates from OwlBot post-processor

c508ab5

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feywind added 2 commits January 12, 2024 14:18

samples: also commit js to work around merging

8822042

chore: merge branch 'schema-revisions' of https://github.com/feywind/…

325f5f6

…nodejs-pubsub into schema-revisions

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024

🦉 Updates from OwlBot post-processor

05d7ff5

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

hongalex approved these changes Jan 17, 2024

View reviewed changes

Merge branch 'main' into schema-revisions

fc1cd9c

kamalaboulhosn approved these changes Jan 18, 2024

View reviewed changes

Comment thread samples/README.md Outdated

Comment thread samples/deleteSchemaRevision.js Outdated

Comment thread samples/typescript/deleteSchemaRevision.ts Outdated

feywind added 2 commits January 22, 2024 12:26

docs: fix incorrect comment in deleteSchemaRevision

a2240ac

chore: merge branch 'schema-revisions' of https://github.com/feywind/…

4053be6

…nodejs-pubsub into schema-revisions

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2024

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2024

gcf-owl-bot Bot and others added 5 commits January 22, 2024 17:31

🦉 Updates from OwlBot post-processor

dacb780

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

samples: add more schema samples, plus tests

ba770a4

chore: merge branch 'schema-revisions' of https://github.com/feywind/…

c0843ec

…nodejs-pubsub into schema-revisions

samples: update sample package.json versions

d72c63e

tests: fix system test for listen with revisions

956b27f

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024

hongalex approved these changes Jan 31, 2024

View reviewed changes

🦉 Updates from OwlBot post-processor

9ff3008

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feywind added the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2024

Merge branch 'main' into schema-revisions

f328879

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024

gcf-merge-on-green Bot merged commit 044e149 into googleapis:main Jan 31, 2024

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2024

release-please Bot mentioned this pull request Jan 31, 2024

chore(main): release 4.2.0 #1875

Merged

feywind deleted the schema-revisions branch January 31, 2024 19:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add schema revision samples#1870

feat: add schema revision samples#1870
gcf-merge-on-green[bot] merged 33 commits into
googleapis:mainfrom
feywind:schema-revisions

feywind commented Jan 5, 2024 •

edited

Loading

Uh oh!

snippet-bot Bot commented Jan 5, 2024 •

edited

Loading

Uh oh!

generated-files-bot Bot commented Jan 10, 2024

Uh oh!

hongalex left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feywind commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

feywind commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot Bot commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

generated-files-bot Bot commented Jan 10, 2024

Uh oh!

hongalex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feywind commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feywind commented Jan 5, 2024 •

edited

Loading

snippet-bot Bot commented Jan 5, 2024 •

edited

Loading