Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

feat: rework low level message stream retries, add debugging#1713

Merged
feywind merged 6 commits into
googleapis:mainfrom
feywind:gh1712-stream-retry
Apr 16, 2023
Merged

feat: rework low level message stream retries, add debugging#1713
feywind merged 6 commits into
googleapis:mainfrom
feywind:gh1712-stream-retry

Conversation

@feywind
Copy link
Copy Markdown
Collaborator

@feywind feywind commented Apr 15, 2023

Adjusts stream retries to standard exponential backoff behaviour, adds a few knobs for tweaking the settings of the backoff, and adds some 'debug' events on the subscription object for seeing when disconnects and reconnects happen.

Fixes #1712

@feywind feywind requested review from a team April 15, 2023 20:36
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 15, 2023
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: l Pull request size is large. labels Apr 15, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2023
@feywind feywind requested a review from kamalaboulhosn April 15, 2023 20:37
Comment thread src/message-stream.ts Outdated
Comment thread src/message-stream.ts Outdated
Comment thread src/message-stream.ts Outdated
Comment thread src/message-stream.ts Outdated
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Apr 15, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve streaming pull stream retry behaviour

2 participants