Skip to content

fix: Remove per-message byte limit in client #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpcollins-google merged 2 commits into from
Jan 12, 2021
Merged

fix: Remove per-message byte limit in client #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7d9d52
fix: Remove per-message byte limit in client
dpcollins-google Dec 22, 2020
311f6fd
fix: clirr
dpcollins-google Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google-cloud-pubsublite/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
<differenceType>8001</differenceType>
<className>com/google/cloud/pubsublite/ProjectLookupUtils</className>
</difference>
<difference>
<differenceType>6011</differenceType>
<className>com/google/cloud/pubsublite/Constants</className>
<field>MAX_PUBLISH_MESSAGE_BYTES</field>
</difference>
<!-- Blanket ignored files -->
<difference>
<differenceType>4001</differenceType>
Expand Down
1 change: 0 additions & 1 deletion google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public class Constants {
.build();

public static final long MAX_PUBLISH_BATCH_COUNT = 1_000;
public static final long MAX_PUBLISH_MESSAGE_BYTES = 1_000_000;
public static final long MAX_PUBLISH_BATCH_BYTES = 3_500_000;

private Constants() {}
Expand Down
16 changes: 0 additions & 16 deletions ...oud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/PublisherImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import com.google.api.gax.batching.BatchingSettings;
import com.google.api.gax.rpc.ApiException;
import com.google.api.gax.rpc.StatusCode.Code;
import com.google.cloud.pubsublite.Constants;
import com.google.cloud.pubsublite.Message;
import com.google.cloud.pubsublite.Offset;
import com.google.cloud.pubsublite.internal.CheckedApiException;
Expand Down Expand Up @@ -203,21 +202,6 @@ private void processBatch(Collection<UnbatchedMessage> batch) throws CheckedApiE
@Override
public ApiFuture<Offset> publish(Message message) {
PubSubMessage proto = message.toProto();
if (proto.getSerializedSize() > Constants.MAX_PUBLISH_MESSAGE_BYTES) {
CheckedApiException error =
new CheckedApiException(
String.format(
"Tried to send message with serialized size %s larger than limit %s on the"
+ " stream.",
proto.getSerializedSize(), Constants.MAX_PUBLISH_MESSAGE_BYTES),
Code.FAILED_PRECONDITION);
try (CloseableMonitor.Hold h = monitor.enter()) {
if (!shutdown) {
onPermanentError(error);
}
}
return ApiFutures.immediateFailedFuture(error);
}
try (CloseableMonitor.Hold h = monitor.enter()) {
ApiService.State currentState = state();
checkState(
Expand Down