Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

docs(samples): add try blocks to clean up resources in samples and sample tests #521

Merged
aribray merged 27 commits into from
Jul 19, 2022
Merged

docs(samples): add try blocks to clean up resources in samples and sample tests #521

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
380f5cb
add try block to clean up resources
aribray Jul 17, 2022
d336117
docs: add try block to clean up resources
aribray Jul 17, 2022
644d764
Merge branch 'aribray--close-resources' of github.com:aribray/java-di…
aribray Jul 17, 2022
48173c9
add try block to clean up resources
aribray Jul 17, 2022
247d799
add try block to clean up resources
aribray Jul 17, 2022
0377870
add Thread.sleep to try blocks, fix checkstyle
aribray Jul 17, 2022
330ad00
add Thread.sleep
aribray Jul 18, 2022
65152dd
add Thread.sleep
aribray Jul 18, 2022
f334e61
add try block to clean up resources
aribray Jul 18, 2022
07b5ace
change fulfillmentInfo tag
aribray Jul 18, 2022
3a63902
add try block to clean up resources
aribray Jul 18, 2022
3282ef2
add ;
aribray Jul 18, 2022
a5d2cac
remove try block
aribray Jul 18, 2022
dc15951
move try block
aribray Jul 18, 2022
339d56f
remove try block
aribray Jul 18, 2022
59479ed
change fulfillmentInfo tag
aribray Jul 18, 2022
a166911
checkstyle
aribray Jul 18, 2022
72c7080
add try block to clean up resources
aribray Jul 18, 2022
4d9513a
add catch
aribray Jul 18, 2022
f2936a8
remove println
aribray Jul 18, 2022
d9cbf0a
checkstyle
aribray Jul 18, 2022
d8fa631
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 18, 2022
3e2f984
add try-with-resources comment to client object creation lines in sni…
aribray Jul 19, 2022
3bc40dd
Merge branch 'aribray--close-resources' of github.com:aribray/java-di…
aribray Jul 19, 2022
2fbdbf5
add string.format
aribray Jul 19, 2022
84a71da
update parentPath
aribray Jul 19, 2022
58cdd11
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
checkstyle 
Change-Id: Ie28023c2bf6422a50dc5e09128ede1e49679c95d
  • Loading branch information
@aribray
aribray committed Jul 18, 2022
commit d9cbf0af2b3a2c7f699b72f12a1008fce3909681
14 changes: 7 additions & 7 deletions samples/snippets/src/test/java/dialogflow/cx/PageManagementIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ public static void tearDown() throws IOException, InterruptedException {

@Test
public void testCreatePage() throws IOException {
try {
Page p = CreateSimplePage.createPage(PROJECT_ID, agentID, flowID, location, displayName);
pageID = p.getName().split("/")[9];
assertThat(p.getDisplayName()).isEqualTo(displayName);
} catch (Exception e) {
assertThat(e).isEqualTo("");
}
try {
Page p = CreateSimplePage.createPage(PROJECT_ID, agentID, flowID, location, displayName);
pageID = p.getName().split("/")[9];
assertThat(p.getDisplayName()).isEqualTo(displayName);
} catch (Exception e) {
assertThat(e).isEqualTo("");
}
}

@Test
Expand Down