Skip to content
This repository was archived by the owner on Jan 22, 2024. It is now read-only.

samples: add Java samples#469

Closed
anweshan wants to merge 27 commits into
googleapis:mainfrom
anweshan:nonrunreportsamples
Closed

samples: add Java samples#469
anweshan wants to merge 27 commits into
googleapis:mainfrom
anweshan:nonrunreportsamples

Conversation

@anweshan
Copy link
Copy Markdown
Contributor

@anweshan anweshan commented Apr 8, 2022

No description provided.

@anweshan anweshan requested review from a team April 8, 2022 23:34
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 8, 2022

Here is the summary of changes.

You are about to add 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: analyticsdata Issues related to the googleapis/java-analytics-data API. samples Issues that are directly related to samples. labels Apr 8, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Apr 8, 2022
@averikitsch
Copy link
Copy Markdown

Thank you for the PR, but it is very large. Can you please split it into different PRs? Take a look at go/cdpe-snippet-rubric and https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md to add thorough comments to the samples. Please use exec:exec not exec:java see GoogleCloudPlatform/java-docs-samples#1523

@anweshan
Copy link
Copy Markdown
Contributor Author

@averikitsch how many samples would you like per PR? I can split up the work done in this one

@averikitsch
Copy link
Copy Markdown

@averikitsch how many samples would you like per PR? I can split up the work done in this one

Thank you, can you separate max 3 samples per PR?

@anweshan
Copy link
Copy Markdown
Contributor Author

Closing PR as content is duplicated in smaller PRs

@anweshan anweshan closed this Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: analyticsdata Issues related to the googleapis/java-analytics-data API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants