This repository was archived by the owner on Jan 22, 2024. It is now read-only.
ci: including all samples in pull request check#451
Closed
suztomo wants to merge 3 commits into
Closed
Conversation
|
Warning: This pull request is touching the following templated files:
|
Member
Author
|
With the modification, the two tests failed as expected at dd6ffc2. |
Member
Author
|
Not needed for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/googleapis/java-analytics-data/issues/431, where the nightly build started failing because RenovateBot pull request #448 reverted Mike's fix last week. The checks should run for normal pull requests, not just nightly builds.