feat: [developerknowledge] new module for developerknowledge#13313
feat: [developerknowledge] new module for developerknowledge#13313cloud-java-bot wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request reorganizes the generation_config.yaml file by moving several API definitions (including bigtable, common-protos, firestore, iam, pubsub, and showcase) into alphabetical order, and adds a new entry for the developerknowledge API. A review comment suggests keeping the client_documentation URL for the new API on a single line instead of wrapping it, to avoid potential parsing issues and improve readability.
| client_documentation: | ||
| https://cloud.google.com/java/docs/reference/google-cloud-developer-knowledge/latest/overview |
There was a problem hiding this comment.
The URL for client_documentation has been wrapped to a new line. While syntactically valid in some YAML parsers, wrapping URLs across lines makes the file harder to read, breaks simple regex-based tools, and can cause parsing issues in stricter YAML parsers.
It is highly recommended to keep the URL on a single line. This wrapping is likely caused by the YAML serializer (e.g., PyYAML) wrapping lines at a default width (usually 80 characters). You can prevent this in the generator script by setting a larger width when dumping the YAML (e.g., width=1000 or width=float('inf') in PyYAML).
client_documentation: https://cloud.google.com/java/docs/reference/google-cloud-developer-knowledge/latest/overview
Generated by @blakeli0 via generate_new_client_hermetic_build.yaml
Command used: