Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Google Cloud Number Registry Client for Java, adding the new java-numberregistry library along with its BOM, parent POM, GRPC, and Proto modules. It also registers the new library in the main GAPIC libraries BOM. The feedback highlights an incomplete description of the service in the README.md file and a typo in a Javadoc code snippet within CloudNumberRegistrySettings.java where OperationalTimedPollAlgorithm should be corrected to OperationTimedPollAlgorithm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add numberregistry library.
This is a test PR, not meant to be merged in.
Steps taken:
librarian update sources.googleapis
librarian add google/cloud/numberregistry/v1alpha
librarian install
librarian generate numberregistry