fix: Package name#14629
Conversation
Packet name is simply wrong, and so are related links.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the pubsub/MIGRATING.md file to correct the package paths for the v2 Pub/Sub Go client, ensuring they point to the specific pubsub directory. The review feedback recommends upgrading the documentation links from http to https for improved security and consistency, as well as removing trailing whitespace from the modified lines.
| * [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2): The new main v2 package. | ||
|
|
||
| * [cloud.google.com/go/v2/apiv1/pubsubpb](http://cloud.google.com/go/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations. | ||
| * [cloud.google.com/go/pubsub/v2/apiv1/pubsubpb](http://cloud.google.com/go/pubsub/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations. |
There was a problem hiding this comment.
The links should use https instead of http for better security and to follow modern web standards. Additionally, there are trailing spaces at the end of lines 15 and 17 that should be removed.
| * [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2): The new main v2 package. | |
| * [cloud.google.com/go/v2/apiv1/pubsubpb](http://cloud.google.com/go/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations. | |
| * [cloud.google.com/go/pubsub/v2/apiv1/pubsubpb](http://cloud.google.com/go/pubsub/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations. | |
| * [cloud.google.com/go/pubsub/v2](https://cloud.google.com/go/pubsub/v2): The new main v2 package. | |
| * [cloud.google.com/go/pubsub/v2/apiv1/pubsubpb](https://cloud.google.com/go/pubsub/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations. |
| The following is an overview of the migration process. You can find more details about the classes in the later part of this document. | ||
|
|
||
| 1. Import the new [cloud.google.com/go/v2](http://cloud.google.com/go/v2) package. | ||
| 1. Import the new [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2) package. |
There was a problem hiding this comment.
The link should use https instead of http for consistency and security.
| 1. Import the new [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2) package. | |
| 1. Import the new [cloud.google.com/go/pubsub/v2](https://cloud.google.com/go/pubsub/v2) package. |
Packet name is simply wrong, and so are related links.