fix(cli): correct settings.json filename in max session turns message#27511
fix(cli): correct settings.json filename in max session turns message#27511crimsondhaks wants to merge 1 commit into
Conversation
The interactive max-session-turns warning displayed in `useGeminiStream`
referenced a non-existent `setting.json` file (singular). The actual
file is `settings.json`. Users searching for the file based on the
message would be unable to find it.
Also rephrase the message to name the actual setting key
(`maxSessionTurns`) and use the same wording already used by the
non-interactive CLI in `errors.ts:211` ("Reached max session turns for
this session. Increase the number of turns by specifying maxSessionTurns
in settings.json."), so users get consistent, actionable guidance in
both interactive and non-interactive modes.
Fixes google-gemini#25889
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user-reported issue where the interactive CLI provided an incorrect filename in its max-session-turns warning. By updating the message, the change ensures users are directed to the correct configuration file and provided with clear instructions on how to adjust their session limits, matching the guidance provided in other parts of the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the warning message displayed when a session reaches its maximum number of turns. It corrects a typo in the configuration file name from 'setting.json' to 'settings.json' and explicitly guides the user to use the 'maxSessionTurns' property to increase the limit. There are no review comments to address, and the changes look correct.
Summary
The interactive max-session-turns warning displayed in
useGeminiStreamreferenced a non-existent
setting.jsonfile (singular). The actual fileis
settings.json. Users searching for the file based on the messagewould be unable to find it, exactly as reported in #25889.
Details
The fix is a single string change in
packages/cli/src/ui/hooks/useGeminiStream.ts:Two improvements in one line:
setting.json→settings.json(the actual bug from Maximum number of turns and theirsetting.jsonfile that doesn't exist #25889).The new wording names the actual setting key (
maxSessionTurns) andmatches the wording already used by the non-interactive CLI for the
same condition in
packages/cli/src/utils/errors.ts:211:So interactive and non-interactive modes now give users the same
actionable guidance.
No tests asserted the previous string, so no test updates were needed.
Related Issues
Fixes #25889
How to Validate
Pre-Merge Checklist
errors.ts