Capitalize letters#14566
Merged
turt2live merged 2 commits intoelement-hq:developfrom Jul 23, 2020
TheEvilSkeleton:develop
Merged
Capitalize letters#14566turt2live merged 2 commits intoelement-hq:developfrom TheEvilSkeleton:develop
turt2live merged 2 commits intoelement-hq:developfrom
TheEvilSkeleton:develop
Conversation
nadonomy
suggested changes
Jul 20, 2020
Contributor
nadonomy
left a comment
There was a problem hiding this comment.
Hey @TheEvilSkeleton thanks for this PR!
Unfortunately we aren't able to merge this as is. Although the logomark & logotype for Matrix includes square brackets, we don't include them when calling Matrix in text/by name.
If you're able to update the string to be 'Powered by Matrix' we can merge.
Contributor
Author
nadonomy
approved these changes
Jul 21, 2020
Contributor
There was a problem hiding this comment.
Thanks @TheEvilSkeleton LGTM!
Approving from my side, also paging @vector-im/riot-web for code review & to confirm this meets contribution guidelines.
turt2live
approved these changes
Jul 23, 2020
refi64
added a commit
to refi64/riot-web-lc
that referenced
this pull request
Jul 28, 2020
[Full Changelog](element-hq/element-web@v1.7.1...v1.7.2) * Upgrade to React SDK 3.0.0 and JS SDK 8.0.0 * Update from Weblate [\element-hq#14778](element-hq#14778) * Capitalize letters [\element-hq#14566](element-hq#14566) * Configure eslint package and fix lint issues [\element-hq#14673](element-hq#14673) * Riot → Element [\element-hq#14581](element-hq#14581) * Remove labs info for the new room list [\element-hq#14603](element-hq#14603) * Convince Webpack to use development on CI [\element-hq#14593](element-hq#14593) * Move dev dep to the right place [\element-hq#14572](element-hq#14572) * Bump lodash from 4.17.15 to 4.17.19 [\element-hq#14552](element-hq#14552) * Update all mobile links to match marketing site [\element-hq#14541](element-hq#14541)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.