[Microsoft Sqlserver] - Ingest instance and server name & query optimisation#4698
Merged
muthu-mps merged 12 commits intoelastic:mainfrom Dec 14, 2022
Merged
Conversation
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| dynamic_counter_name: "{{dynamic_counter_name}}" | ||
| driver: "mssql" | ||
| sql_queries: | ||
| - query: "SELECT @@servername AS server_name, @@servicename AS instance_name;" |
Contributor
There was a problem hiding this comment.
Can we add a section to the documentation, how the server_name and instance_name populated with an example?
Contributor
Author
|
relates to #4259 |
| ### Query by Instance Name or Server Name in Kibana | ||
|
|
||
| The data can be visualized in Kibana by filtering based on the instance name and server name. The instance name can be filtered by `mssql.metrics.instance_name` and server name by `mssql.metrics.server_name` fields. | ||
|
|
ritalwar
approved these changes
Dec 14, 2022
efd6
approved these changes
Dec 14, 2022
|
Package microsoft_sqlserver - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ingests the instance name and server name.
Fine tuned the query and removed the hardcoding of database names in the response.
Pending
The Kibana visualisation support for filtering the data based on instance name needs to be done
Checklist
changelog.ymlfile.How to test this PR locally
Run system test and verify the instance and server name fields are getting ingested for both the datastreams.
Related issues
Screenshots