[microsoft_sqlserver] change default username value to be properly encoded#16191
Merged
mykola-elastic merged 2 commits intomainfrom Dec 3, 2025
Merged
[microsoft_sqlserver] change default username value to be properly encoded#16191mykola-elastic merged 2 commits intomainfrom
mykola-elastic merged 2 commits intomainfrom
Conversation
As per field description:
"Domain users: Pre-encode username when passing backslash e.g. {domain}%5C{username} instead of {domain}\\\\{username}" Using %5C (encoded backslash) in the connection string default value
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
shmsr
approved these changes
Dec 3, 2025
Linu-Elias
approved these changes
Dec 3, 2025
|
Package microsoft_sqlserver - 2.14.1 containing this change is available at https://epr.elastic.co/package/microsoft_sqlserver/2.14.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per field description:
"Domain users: Pre-encode username when passing backslash e.g. {domain}%5C{username} instead of {domain}\\{username}"
Using %5C (encoded backslash) in the username string default value to be consistent with the requirement.
Also, see #15161 (comment)
Proposed commit message
See title.
Checklist
I have verified that all data streams collect metrics or logs.changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.I have verified that any added dashboard complies with Kibana's Dashboard good practicesRelated issues