[HAProxy] set event.module and event.dataset#1233
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
| release: experimental | ||
| conditions: | ||
| kibana.version: "^7.13.0" | ||
| kibana.version: "^7.14.0" |
There was a problem hiding this comment.
Why is this change needed? Wouldn't be better if users of 7.13 can already benefit from this change?
There was a problem hiding this comment.
I think we agreed before not to release changes for older stacks if it isn't necessary. This way changes are added only the latest one.
@andresrc I hope that's ok?
There was a problem hiding this comment.
Ok, let's continue like this if this is the current convention, but I think this artificially couples packages to versions of the stack, ideally packages should depend on the minor version of the stack that they require to work. Changes that don't affect compatibility with shouldn't need to update this.
This way newer packages could be used by users of older, but otherwise compatible, Kibana versions.
What does this PR do?
This PR adds
event.moduleandevent.datasetto the integration.Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).