darktrace: fix handling of acknowledgement in model_breach_alert#11517
darktrace: fix handling of acknowledgement in model_breach_alert#11517efd6 merged 2 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
left a comment
There was a problem hiding this comment.
Minor clarifications.
LGTM
| ctx.darktrace.model_breach_alert.is_acknowledged = false; | ||
| return; | ||
| } | ||
| if (ctx.darktrace?.model_breach_alert?.acknowledged.time == null) { |
There was a problem hiding this comment.
At this point, we know that ctx.darktrace.model_breach_alert.acknowledged is not null, because it didn't return.
So, no need for having null checks in subsequent steps for darktrace?.model_breach_alert?
| fields: | ||
| - name: time | ||
| type: date | ||
| - name: username |
There was a problem hiding this comment.
username could be added to related.users
💚 Build Succeeded
History
cc @efd6 |
|
|
Package darktrace - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=darktrace |
Proposed commit message
See title.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots