[tines] Fix template rendering error when there's no auth_email#11458
Merged
chrisberkhout merged 3 commits intoelastic:mainfrom Oct 18, 2024
chrisberkhout:tines-no-auth-email
Merged
[tines] Fix template rendering error when there's no auth_email#11458chrisberkhout merged 3 commits intoelastic:mainfrom chrisberkhout:tines-no-auth-email
chrisberkhout merged 3 commits intoelastic:mainfrom
chrisberkhout:tines-no-auth-email
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
Can you pick up the test additions that I did for this in #11459. |
5 tasks
|
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
Package tines - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=tines |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…tic#11458) Don't populate a `X-User-Email` header if the `auth_email` variable is not set. The variable is not required, but when it's not present there is a template failure while trying to populate the `X-User-Email` header. That header isn't currently mentioned in the Tines API documentation. It only requires `X-User-Token`. --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…tic#11458) Don't populate a `X-User-Email` header if the `auth_email` variable is not set. The variable is not required, but when it's not present there is a template failure while trying to populate the `X-User-Email` header. That header isn't currently mentioned in the Tines API documentation. It only requires `X-User-Token`. --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Related issues