bitdefender: ensure remediation actions are correlated with their file paths#11013
Merged
efd6 merged 2 commits intoelastic:mainfrom Sep 10, 2024
Merged
bitdefender: ensure remediation actions are correlated with their file paths#11013efd6 merged 2 commits intoelastic:mainfrom
efd6 merged 2 commits intoelastic:mainfrom
Conversation
e61451d to
7582217
Compare
…e paths The .filePaths, .fileSizes and .remediationActions are correlated arrays, so ensure that empty actions are not removed from the array to maintain their cardinality relationships.
7582217 to
c1424e6
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
push_configuration |
33333.33 | 23809.52 | -9523.81 (-28.57%) | 💔 |
push_statistics |
58823.53 | 38461.54 | -20361.99 (-34.62%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
approved these changes
Sep 9, 2024
Contributor
kcreddy
left a comment
There was a problem hiding this comment.
Minor clarification. Otherwise LGTM 👍🏼
| } | ||
| return false; | ||
| } | ||
| ctx.bitdefender?.event?.remediationActions?.replaceAll(e -> e == "" ? "-" : e); |
Contributor
There was a problem hiding this comment.
Do you think similar change for filePaths and fileSizes is also required?
Contributor
Author
There was a problem hiding this comment.
I don't think so, but I will add them. The semantics are that this can be empty if there is no remediation, but the others would only be empty due to error.
|
💚 Build Succeeded
History
cc @efd6 |
|
Package bitdefender - 2.1.1 containing this change is available at https://epr.elastic.co/search?package=bitdefender |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…e paths (elastic#11013) The .filePaths, .fileSizes and .remediationActions are correlated arrays, so ensure that empty actions are not removed from the array to maintain their cardinality relationships.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…e paths (elastic#11013) The .filePaths, .fileSizes and .remediationActions are correlated arrays, so ensure that empty actions are not removed from the array to maintain their cardinality relationships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The .filePaths, .fileSizes and .remediationActions fields are correlated arrays, so ensure that empty actions are not removed from the array to maintain their cardinality relationships.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots