Skip to content

wiz: fix input error handling in ingest pipeline#10318

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:wiz_errors
Jul 2, 2024
Merged

wiz: fix input error handling in ingest pipeline#10318
efd6 merged 1 commit intoelastic:mainfrom
efd6:wiz_errors

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jul 1, 2024

Proposed commit message

Also add redact.fields entry to suppress redaction warning.


Manually checked behaviour by changing 200 status codes in system test deployment to 401. Correct behaviour observed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bugfix Pull request that fixes a bug issue Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 1, 2024
@efd6 efd6 self-assigned this Jul 1, 2024
Also add redact.fields entry to suppress redaction warning.
@elasticmachine
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@elastic-sonarqube
Copy link
Copy Markdown

@efd6 efd6 marked this pull request as ready for review July 1, 2024 21:17
@efd6 efd6 requested a review from a team as a code owner July 1, 2024 21:17
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor clarification.
The change LGTM 👍🏼

Comment on lines -4 to +11
- fail:
if: ctx.error?.message != null && ctx.message == null && ctx.event?.original == null
message: error message set and no data to process
- set:
field: ecs.version
tag: set_ecs_version
value: '8.11.0'
- fail:
tag: cel_failure
if: ctx.error?.message != null && ctx.message == null && ctx.event?.original == null
message: error message set and no data to process
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know what this change intends to do? Just trying to get some context for moving this processor.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should always have the ecs version in an ingested document. This is incidental to the main focus of the change, but fixes this single data stream where I had not made the change in the previous PR (note that the other two data streams are already in this state).

@efd6 efd6 merged commit dc3ad43 into elastic:main Jul 2, 2024
@elasticmachine
Copy link
Copy Markdown

Package wiz - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=wiz

@efd6 efd6 deleted the wiz_errors branch February 5, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants