[WIP] Implement delegate inspection DacDbi APIs on cDAC#128784
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
GetDelegateFunctionDataandGetDelegateTargetObjectin the managed cDAC DacDbi layer, on top of cherry-picked native commit86d4004which removesGetDelegateTypeand simplifies the two delegate APIs' signatures.cDAC contract
IObject.GetDelegateInfo(addr, out methodPtr, out methodPtrAux, out invocationCount)implemented inObject_1via a newData.Delegatetype. No version bump; no compat shims for older dumps.Data descriptors
cdac_data<DelegateObject>template + friend insrc/coreclr/vm/object.h.Delegatetype indatadescriptor.incwithTarget,MethodPtr,MethodPtrAux,InvocationList,InvocationCount.DataType.Delegateenum value.DacDbi cDAC implementations
DacDbiImpl.GetDelegateFunctionData/GetDelegateTargetObjectimplemented using the new contract +ExecutionManager,RuntimeTypeSystem, andLoadercontracts. Delegate-kind branching (closed / open / multicast / wrapper) mirrors the native logic.#if DEBUGvalidation against the legacy implementation (Debug.ValidateHResult+Debug.Asserton outputs).CORDBG_E_UNSUPPORTED_DELEGATEHR constant.GetDelegateTypeis dropped inIDacDbiInterface.csto match the native interface.Native fix-up
HRESULTdeclaration atdivalue.cpp:2725introduced by the cherry-pick.Unit tests
MockDelegateObjectData+AddDelegateObjecthelpers inMockDescriptors.Object.cs.ObjectTestscases forGetDelegateInfo: closed delegate, open delegate, multicast delegate, and null-address argument validation.