Skip to content

Fix #14717 (FP: same exprId for different expressions leads to wrong redundantAssignment) #8520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danmar wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −16
Open

Fix #14717 (FP: same exprId for different expressions leads to wrong redundantAssignment) #8520

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2af547
Fix #14717 (FP: same exprId for different expressions leads to wrong …
danmar May 2, 2026
d301b6a
review
danmar May 2, 2026
f317645
FollowAllReferences: Use Token::index() to get stable sorting order
danmar May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
FollowAllReferences: Use Token::index() to get stable sorting order
  • Loading branch information
@danmar
danmar committed May 6, 2026
commit f31764541a050e4ac25774989b95b9db563a4287
2 changes: 1 addition & 1 deletion lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ static SmallVector<ReferenceToken> followAllReferencesInternal(const Token* tok,
{
struct ReferenceTokenLess {
bool operator()(const ReferenceToken& x, const ReferenceToken& y) const {
return x.token < y.token;
return x.token->index() < y.token->index();
}
};
if (!tok)
Expand Down
Loading