Update graphql codegen setup#73
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
bluwy
commented
May 29, 2026
Comment on lines
+4
to
+16
| const schemaPath = "node_modules/.cache/github-graphql-schema.graphql"; | ||
|
|
||
| if (process.env.CI || !fs.existsSync(schemaPath)) { | ||
| const result = await fetch( | ||
| "https://docs.github.com/public/fpt/schema.docs.graphql", | ||
| ); | ||
| if (!result.ok) { | ||
| throw new Error( | ||
| `Failed to fetch GitHub GraphQL schema: ${result.status} ${result.statusText}`, | ||
| ); | ||
| } | ||
| fs.writeFileSync(schemaPath, await result.text()); | ||
| } |
Member
Author
There was a problem hiding this comment.
I added this code instead of using @octokit/graphql-schema because the package had outdated schema for a while now (due to npm token changes), so this will allow us to work with more up-to-date APIs.
I implemented caching here so that we don't always fetch the schema everytime we run codegen.
Comment on lines
+25
to
+26
| // TODO: Look into adding stricter types or use `unknown` | ||
| defaultScalarType: "any", |
Member
Author
There was a problem hiding this comment.
This is mainly for compat with the previous codegen to prevent type errors, as it'd default to unknown. We should look into this later.
Andarist
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update its dependencies and its new setup (handling its breaking changes)