Skip to content

✨ Add support for Wunderkind Auto AMP Ads#35222

Merged
calebcordry merged 12 commits into
ampproject:mainfrom
weirdian2k3:main
Jul 20, 2021
Merged

✨ Add support for Wunderkind Auto AMP Ads#35222
calebcordry merged 12 commits into
ampproject:mainfrom
weirdian2k3:main

Conversation

@weirdian2k3
Copy link
Copy Markdown
Contributor

This PR provides support for <amp-auto-ads type="wunderkind" />

Closes #35207

@amp-owners-bot amp-owners-bot Bot requested a review from calebcordry July 14, 2021 14:36
… Image Polls (#35205)

* Add fill animation

* Add bubble post-selection animation

* Move background color percentage fill to post selection styles
@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet, @mszylkowski! These files were changed:

extensions/amp-story-interactive/0.1/amp-story-interactive-img-quiz.css
extensions/amp-story-interactive/0.1/amp-story-interactive-img.css
extensions/amp-story-interactive/0.1/amp-story-interactive-quiz.css
extensions/amp-story-interactive/0.1/amp-story-interactive.css

Comment thread extensions/amp-auto-ads/0.1/test/test-wunderkind-network-config.js Outdated
Comment thread extensions/amp-auto-ads/0.1/wunderkind-network-config.js Outdated
Comment thread extensions/amp-auto-ads/0.1/wunderkind-network-config.js Outdated
@weirdian2k3 weirdian2k3 requested a review from calebcordry July 15, 2021 14:42
Comment thread extensions/amp-auto-ads/0.1/test/test-wunderkind-network-config.js Outdated
@weirdian2k3 weirdian2k3 requested a review from calebcordry July 19, 2021 13:43
@calebcordry calebcordry enabled auto-merge (squash) July 19, 2021 23:17
@calebcordry
Copy link
Copy Markdown
Member

@weirdian2k3 it looks like our CI is having trouble calculating the commit, could you sync to main?

auto-merge was automatically disabled July 20, 2021 13:31

Head branch was pushed to by a user without write access

@weirdian2k3
Copy link
Copy Markdown
Contributor Author

@weirdian2k3 it looks like our CI is having trouble calculating the commit, could you sync to main?

@calebcordry I think I found the issue. CircleCI wasn't reporting the failure to Github, but there were test failures in CircleCI. I went ahead and fixed those and I think we may be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wunderkind extension for amp-auto-ads

4 participants